Skip to content

fix(aws-transform): stop blocking native Windows in custom workflow platform check - #213

Open
thalisantunes wants to merge 1 commit into
kirodotdev:mainfrom
thalisantunes:fix/aws-transform-windows-platform-check
Open

thalisantunes wants to merge 1 commit into
kirodotdev:mainfrom
thalisantunes:fix/aws-transform-windows-platform-check

Conversation

@thalisantunes

Copy link
Copy Markdown

Fixes #198

steering/workload-custom.md had a "0. Platform Check" that stopped native Windows users and sent them to WSL. The official AWS Transform custom docs say native Windows is supported:

Windows - Full support for native Windows using Windows Terminal and PowerShell (The atx ct commands are not yet supported on Windows)

Source: https://docs.aws.amazon.com/transform/latest/userguide/custom-get-started.html

The only Windows limitation is atx ct (continuous modernization), a separate workflow.

The check was also unreliable. It ran uname -s and treated "command not found" as native Windows, but uname does not exist in PowerShell, so it blocked a supported environment because the probe itself was missing.

Changes:

  • workload-custom.md: replace the WSL-only block and the uname probe with a short platform note (native Windows and WSL supported; atx ct not yet supported on native Windows).
  • workload-custom-troubleshooting.md: the "Windows not supported" row now says only atx ct is unsupported on native Windows.
  • POWER.md: version 2.8.0 -> 2.8.1, following the pattern of earlier aws-transform fixes. Happy to drop this if maintainers bump versions themselves.

Verification:

  • Checked the quoted sentence against the live docs page.
  • Not tested on Windows by me. The issue reporter confirmed atx --version, atx update and atx custom def list --json run on native Windows with PowerShell 7 (CLI 3.13.0), and that removing the block let the custom workflow run.
  • The repo has no validator for steering content; this is a markdown-only change.
  • Other steps in workload-custom.md (for example the Linux/macOS install hints for the AWS CLI) were not reviewed for Windows wording and are left unchanged.

…latform check

atx custom is supported on native Windows (Windows Terminal and
PowerShell) per the AWS Transform custom getting-started docs; only
atx ct is not yet supported there. Replace the WSL-only block and the
uname probe with a platform note, update the troubleshooting row, and
bump aws-transform to 2.8.1.

Fixes kirodotdev#198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workload-custom.md "0. Platform Check" wrongly blocks native Windows (which atx custom supports)

1 participant